✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	98534bf
🔍 Latest deploy log	https://app.netlify.com/sites/olmv1/deploys/66840d1970c23f00081132c6
😎 Deploy Preview	https://deploy-preview-1004--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.19%. Comparing base (872b7f7) to head (98534bf).

@@           Coverage Diff           @@
##             main    #1004   +/-   ##
=======================================
  Coverage   77.19%   77.19%           
=======================================
  Files          17       17           
  Lines        1206     1206           
=======================================
  Hits          931      931           
  Misses        193      193           
  Partials       82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I noticed this was broken recently as well. But I know @tmshort added it fairly recently, so maybe worth getting his opinion on this PR.

I noticed this was broken recently as well. But I know @tmshort added it fairly recently, so maybe worth getting his opinion on this PR.

Uh.. it looks like the line got sucked out the airlock in b08a1e9 Should we just put OPERATOR_CONTROLLER_NAMESPACE ?= operator-controller-system and fix the target?

I noticed this was broken recently as well. But I know @tmshort added it fairly recently, so maybe worth getting his opinion on this PR.

Uh.. it looks like the line got sucked out the airlock in b08a1e9 Should we just put OPERATOR_CONTROLLER_NAMESPACE ?= operator-controller-system and fix the target?

I'm not opposed to doing this, but my preference is to remove it. IMO our Makefile is getting a bit cluttered. Also we have tilt setup for quick redeployment which watches filesystem and automates dev process. We can also run it locally with port forwarding or just make run (which is a bit slower and does not persist resources because the kind cluster gets re-created).

But it is just me. If people find it useful for their workflows - then it might be worth keeping it.

This is something that @joelanford had asked for, and I think I noticed that OPERATOR_CONTROLLER_NAMESPACE was not being properly set, either, but it got away from me with other work. I don't have a Tilt setup yet, so, I'm one of those where this might be useful.

Added #1032 to actually fix kind-redeploy, but it's really just running other targets...

I'm +1 on removing now that Tilt is actually working properly.